Skip to content

fix: hardcode azure instance identity intermediate certificates #6402

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 1, 2023
Merged

fix: hardcode azure instance identity intermediate certificates #6402

merged 1 commit into from
Mar 1, 2023

Conversation

kylecarbs
Copy link
Member

This was broken for an airgapped customer!

@kylecarbs
fix: hardcode azure instance identity intermediate certificates
26b72e2 
This was broken for an airgapped customer!
@kylecarbs kylecarbs requested a review from deansheather March 1, 2023 17:16
@kylecarbs kylecarbs self-assigned this Mar 1, 2023
deansheather
deansheather reviewed Mar 1, 2023
View reviewed changes
Copy link
Member

@deansheather deansheather left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To avoid breaking all customers when these certs change, this should try the hardcoded certs, and if they don't match then try to download the certs from the server.

@kylecarbs kylecarbs enabled auto-merge (squash) March 1, 2023 17:35
@kylecarbs kylecarbs merged commit 9ea21bf into main Mar 1, 2023
@kylecarbs kylecarbs deleted the azureairgapped branch March 1, 2023 17:39
@github-actions github-actions bot locked and limited conversation to collaborators Mar 1, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@deansheather deansheather deansheather approved these changes

Assignees

@kylecarbs kylecarbs

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kylecarbs @deansheather