Skip to content

chore: use go 1.18 everywhere in ci #641

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 29, 2022
Merged

chore: use go 1.18 everywhere in ci #641

merged 1 commit into from
Mar 29, 2022

Conversation

coadler
Copy link
Contributor

@coadler coadler commented Mar 29, 2022

Somehow I missed these?

@coadler
chore: use go 1.18 everywhere in ci
0aeeb32 
Somehow I missed these?
@coadler coadler self-assigned this Mar 29, 2022
kylecarbs
kylecarbs approved these changes Mar 29, 2022
View reviewed changes
Copy link
Member

@kylecarbs kylecarbs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Odd that it all worked........

@coadler coadler enabled auto-merge (squash) March 29, 2022 19:05
@codecov
Copy link

codecov bot commented Mar 29, 2022

Codecov Report

Merging #641 (0aeeb32) into main (1bab7e8) will decrease coverage by 0.43%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main     #641      +/-   ##
==========================================
- Coverage   64.53%   64.09%   -0.44%     
==========================================
  Files         198      111      -87     
  Lines       11622    10547    -1075     
  Branches       85        0      -85     
==========================================
- Hits         7500     6760     -740     
+ Misses       3333     3020     -313     
+ Partials      789      767      -22
Flag Coverage Δ
unittest-go- 63.47% <ø> (-0.14%) ⬇️
unittest-go-macos-latest ?
unittest-go-ubuntu-latest 62.15% <ø> (-0.05%) ⬇️
unittest-go-windows-2022 ?
unittest-js ?
Impacted Files Coverage Δ
pty/start_other.go 64.70% <0.00%> (-23.53%) ⬇️
provisionersdk/transport.go 78.72% <0.00%> (-6.39%) ⬇️
cli/cliui/agent.go 76.78% <0.00%> (-5.36%) ⬇️
pty/ptytest/ptytest.go 89.65% <0.00%> (-5.18%) ⬇️
peer/conn.go 77.15% <0.00%> (-4.83%) ⬇️
cli/projectinit.go 56.36% <0.00%> (-3.64%) ⬇️
peerbroker/listen.go 84.16% <0.00%> (-3.34%) ⬇️
provisioner/echo/serve.go 54.40% <0.00%> (-2.40%) ⬇️
coderd/workspaceresources.go 59.72% <0.00%> (-1.81%) ⬇️
provisionerd/provisionerd.go 79.44% <0.00%> (-1.62%) ⬇️
... and 90 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1bab7e8...0aeeb32. Read the comment docs.

@coadler coadler merged commit b33e457 into main Mar 29, 2022
@coadler coadler deleted the colin/more-1.18 branch March 29, 2022 19:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kylecarbs kylecarbs kylecarbs approved these changes

Assignees

@coadler coadler

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@coadler @kylecarbs