feat: Implement joins with golang templates #6429
Conversation
Removes the need to fetch the workspace to run an rbac check.
| // "$1, $2" instead of "$1, $1". | ||
| // 2. SQLx does not handle uuid arrays. | ||
| // 3. SQLx only supports ":name" style arguments and breaks "::" type casting. | ||
| func bindNamed(query string, arg interface{}) (newQuery string, args []interface{}, err error) { |
There was a problem hiding this comment.
Is there no other way around this? I really dislike the regexp rewriting and reflection on every single query.
Is sqlx not smarter than this?
There was a problem hiding this comment.
Actually SQLx is a bit dummber. I took this code implementation from SQLx and changed some things. The usage for SQLx is sqlx.Named(). But it doesn't handle things that I put in the function comments, so I adjusted it.
https://github.com/jmoiron/sqlx/blob/master/named.go#LL421-L436C2
Instead of a regex, they wrote a more proper parser: https://github.com/jmoiron/sqlx/blob/master/named.go#L331
But the parser doesn't work. It parses comments and they use :arg as arguments, so when we typecast with ::, it's seen as escaping a colon literal. So our sql queries would have to do ::::.
The SQLx parser is honestly really dumb with actual SQL.
Golang template alternative to #6371
What this does
This adds database joins and dynamic SQL queries. I only did this for workspace builds in this PR. Read the other PR and this issue: #6426.
Fixes: #6426
Next work
I will use templates for authorized queries next, remove the strings replace.