CLI create: support for optional fields

coder · mtojek · Mar 7, 2023 · Mar 3, 2023 · Mar 3, 2023 · Mar 3, 2023
commit e804f40ccac468f0a75dba44498347ab7dd48238
diff --git a/cli/cliui/parameter.go b/cli/cliui/parameter.go
@@ -85,7 +85,7 @@ func RichParameter(cmd *cobra.Command, templateVersionParameter codersdk.Templat
 		}
 	} else {
 		text := "Enter a value"
-		if templateVersionParameter.DefaultValue != "" {
+		if !templateVersionParameter.Required {
 			text += fmt.Sprintf(" (default: %q)", templateVersionParameter.DefaultValue)
 		}
 		text += ":"

diff --git a/codersdk/richparameters.go b/codersdk/richparameters.go
@@ -30,7 +30,11 @@ func ValidateWorkspaceBuildParameters(richParameters []TemplateVersionParameter,
 
 func ValidateWorkspaceBuildParameter(richParameter TemplateVersionParameter, buildParameter WorkspaceBuildParameter, lastBuildParameter *WorkspaceBuildParameter) error {
 	value := buildParameter.Value
-	if value == "" {
+	if value == "" && richParameter.Required {
+		return xerrors.Errorf("parameter value is required")
+	}
+
+	if value == "" { // parameter is optional
 		value = richParameter.DefaultValue
 	}