chore(cli)!: change default max-token-duration to unlimited #6467
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Kira-Pilot
commented
Mar 6, 2023
| Usage: "The maximum lifetime duration users can specify when creating an API token.", | ||
| Flag: "max-token-lifetime", | ||
| // max time.Duration is 290 years | ||
| Default: 290 * 365 * 24 * time.Hour, |
There was a problem hiding this comment.
According to the docs, the max time.Duration one can set is 290 years. If there's a cleaner way to represent this max, let me know.
There was a problem hiding this comment.
A cleaner way to do this is time.Duration(math.MaxInt64)
There was a problem hiding this comment.
Thanks! I'll follow up in my next PR!
There was a problem hiding this comment.
for fun: https://go.dev/play/p/YtHsPbOIR-N
bpmct
reviewed
Mar 6, 2023
There was a problem hiding this comment.
Thanks for doing this, Kira. This is technically a breaking change, so can you label it as such?
Thinking we can change the title to: chore: change default max-token-duration to unlimited
mtojek
approved these changes
Mar 7, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Product has requested that token lifetimes follow the below rules:
Make default of
--max-token-lifetimeunlimited.Make default lifetime of
coder tokens create30 days, but then another lifetime can be set with--lifetimeup to the max (set by server).