-
Notifications
You must be signed in to change notification settings - Fork 928
feat: convert rest of CLI to clibase #6491
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
17fa3f4
to
aee8ae9
Compare
* RunContext -> WithContext * Stdin/Stdout wiring
* More stdio wiring
Started refactoring production code too 🥴
- Fix output formats
* SO much
* Some server.go fixes
All useclients
Pretty up cliui logs
* Everything, everywhere is broken
* Some commands are transitioned
* Fixed server.go
* Massive fixup in clibase command parsing
* Start the enterprise
mafredri
approved these changes
Mar 23, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this is as polished as we'll get it, confirmed via golden file output tweaks that we got all the major differences ironed out and ran some manual command tests which caught a few issues, which are now fixed.
Giving a green light for merge once CI passes! 👍🏻
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up from #6347
Now
cli/server_test.go
to use "clitest.Start" for better cleanup and error reportingcliflag
packagecobra
is no longer importedFormatCobraError
Later
clitest.Start
.Option.Default
in favor of using whatever is stored inOption.Value
. (clibase: use Value instead of Default #6697)