Skip to content

feat: convert rest of CLI to clibase #6491

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 192 commits into from
Mar 23, 2023
Merged

feat: convert rest of CLI to clibase #6491

merged 192 commits into from
Mar 23, 2023

Conversation

ammario
Copy link
Member

@ammario ammario commented Mar 7, 2023

Follow up from #6347

Now

  • Generate CLI docs again
  • Convert the rest of the CLI to bigcli
  • Refactor rest of cli/server_test.go to use "clitest.Start" for better cleanup and error reporting
  • Regenerate golden files
  • Remove cliflag package
  • Verify that cobra is no longer imported
  • Removed FormatCobraError
  • Ensure Output formatting (e.g. JSON) continues working
  • Make sure GIT ASKPASS continues working (environment variable jiu-jitsu)
  • Test ReadGitAuthEnv

Later

@ammario ammario force-pushed the clibase-all branch 4 times, most recently from 17fa3f4 to aee8ae9 Compare March 7, 2023 21:04
ammario added 5 commits March 8, 2023 03:53
* Some commands are transitioned
* Fixed server.go
* Massive fixup in clibase command parsing
* Start the enterprise
Copy link
Member

@mafredri mafredri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is as polished as we'll get it, confirmed via golden file output tweaks that we got all the major differences ironed out and ran some manual command tests which caught a few issues, which are now fixed.

Giving a green light for merge once CI passes! 👍🏻

@ammario ammario merged commit 2bd6d29 into main Mar 23, 2023
@ammario ammario deleted the clibase-all branch March 23, 2023 22:42
@github-actions github-actions bot locked and limited conversation to collaborators Mar 23, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants