Skip to content

Conversation

mtojek
Copy link
Member

@mtojek mtojek commented Mar 9, 2023

Related: #6074

Preview: link

This PR adds a doc page describing rich parameters.

@mtojek mtojek self-assigned this Mar 9, 2023
@mtojek mtojek requested a review from bpmct March 9, 2023 12:01
@mtojek mtojek marked this pull request as ready for review March 9, 2023 12:03
@mtojek mtojek requested review from mafredri and johnstcn March 9, 2023 12:29
@mtojek mtojek marked this pull request as draft March 9, 2023 12:43
@mtojek mtojek marked this pull request as draft March 9, 2023 12:43
@mtojek
Copy link
Member Author

mtojek commented Mar 9, 2023

Back to draft, I need to check one thing...

Copy link
Member

@johnstcn johnstcn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some wording suggestions, in particular "admin" -> "template author".
Looks good otherwise!

}

variable "cpu" {
sensitive = false # User (workspace-level) parameter
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
sensitive = false # User (workspace-level) parameter
sensitive = false # User parameter (may be edited when creating a workspace)

mtojek and others added 11 commits March 9, 2023 16:57
Co-authored-by: Cian Johnston <public@cianjohnston.ie>
Co-authored-by: Cian Johnston <public@cianjohnston.ie>
Co-authored-by: Cian Johnston <public@cianjohnston.ie>
Co-authored-by: Cian Johnston <public@cianjohnston.ie>
Co-authored-by: Cian Johnston <public@cianjohnston.ie>
Co-authored-by: Cian Johnston <public@cianjohnston.ie>
Co-authored-by: Cian Johnston <public@cianjohnston.ie>
Co-authored-by: Cian Johnston <public@cianjohnston.ie>
Co-authored-by: Cian Johnston <public@cianjohnston.ie>
@mtojek mtojek marked this pull request as ready for review March 9, 2023 16:07
@mtojek mtojek merged commit c2787e3 into coder:main Mar 9, 2023
@github-actions github-actions bot locked and limited conversation to collaborators Mar 9, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants