Skip to content

fix: remove "something went wrong" text for watching a workspace #6541

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 9, 2023

Conversation

kylecarbs
Copy link
Member

@kylecarbs kylecarbs commented Mar 9, 2023

This text wasn't useful to a customer anyways, because we don't get an error from EventSource. This can happen if you close your laptop and open it again, so it's better if we don't display it.

Fixes #6423
Fixes #6274

@kylecarbs kylecarbs requested a review from BrunoQuaresma March 9, 2023 20:21
@kylecarbs kylecarbs self-assigned this Mar 9, 2023
@kylecarbs kylecarbs force-pushed the somethingwentwrong branch 2 times, most recently from c6f24ec to dccc11d Compare March 9, 2023 20:34
This text wasn't useful to a customer anyways, because we don't get
an error from EventSource. This can happen if you close your laptop
and open it again, so it's better if we don't display it.
@kylecarbs kylecarbs force-pushed the somethingwentwrong branch from dccc11d to 513f09a Compare March 9, 2023 20:42
@kylecarbs kylecarbs enabled auto-merge (squash) March 9, 2023 20:46
@kylecarbs kylecarbs merged commit 65878b0 into main Mar 9, 2023
@kylecarbs kylecarbs deleted the somethingwentwrong branch March 9, 2023 20:54
@github-actions github-actions bot locked and limited conversation to collaborators Mar 9, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
2 participants