fix: Prevent infinite redirects on oidc errors #6550
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
johnstcn
approved these changes
Mar 10, 2023
johnstcn
reviewed
Mar 10, 2023
| // if for example we are providing and invalid scope. | ||
| // We should terminate the OIDC process if we encounter an error. | ||
| oidcError := r.URL.Query().Get("error") | ||
| errorDescription := r.URL.Query().Get("error_description") |
There was a problem hiding this comment.
Per the OIDC spec only the error response parameter is required; the error_description field is optional so we should handle that being blank.
Also there is an error_uri parameter that might be present so we should check for that as well.
There was a problem hiding this comment.
I do handle an empty error_description. The Details part of the error is extra developer debug info. If it is empty, we provide no extra details, since we have no extra information.
I can add error_uri though 👍
kylecarbs
approved these changes
Mar 10, 2023
johnstcn
approved these changes
Mar 10, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Providing an invalid scope
-oidc-scopes openid,profile,email,badon Okta OIDC provider causes infinite redirect loop.