Skip to content

fix: panic on deleted template #6553

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 10, 2023
Merged

fix: panic on deleted template #6553

merged 1 commit into from
Mar 10, 2023

Conversation

mtojek
Copy link
Member

@mtojek mtojek commented Mar 10, 2023 •
edited
Loading

This PR fixes the following panic:

[API] 2023-03-10 10:49:15.895 [WARN]	(coderd)	<./coderd/httpmw/recover.go:19>	Recover.func1.1.1	panic serving http request (recovered)	{"panic": "runtime error: index out of range [0] with length 0"} ...
[API] "stack": goroutine 8141 [running]:
[API]          runtime/debug.Stack()
[API]          	/nix/store/79z3m4iw5y7sj5mk4w7rs37vzlian9dj-go-1.20/share/go/src/runtime/debug/stack.go:24 +0x64
[API]          github.com/coder/coder/coderd/httpmw.Recover.func1.1.1()
[API]          	/Users/mtojek/code/coder/coderd/httpmw/recover.go:22 +0x5c
[API]          panic({0x116b9ffe0, 0x1400162e090})
[API]          	/nix/store/79z3m4iw5y7sj5mk4w7rs37vzlian9dj-go-1.20/share/go/src/runtime/panic.go:884 +0x1f4
[API]          go.opentelemetry.io/otel/sdk/trace.(*recordingSpan).End.func1()
[API]          	/Users/mtojek/go/pkg/mod/go.opentelemetry.io/otel/sdk@v1.11.1/trace/span.go:383 +0x2c
[API]          go.opentelemetry.io/otel/sdk/trace.(*recordingSpan).End(0x1400160d080, {0x0, 0x0, 0x1?})
[API]          	/Users/mtojek/go/pkg/mod/go.opentelemetry.io/otel/sdk@v1.11.1/trace/span.go:421 +0x7e4
[API]          panic({0x116b9ffe0, 0x1400162e090})
[API]          	/nix/store/79z3m4iw5y7sj5mk4w7rs37vzlian9dj-go-1.20/share/go/src/runtime/panic.go:884 +0x1f4
[API]          github.com/coder/coder/coderd.(*API).workspaceByOwnerAndName(0x140011ae000, {0x116cf4470, 0x1400123c480}, 0x140019e7d00)
[API]          	/Users/mtojek/code/coder/coderd/workspaces.go:262 +0xa70
[API]          net/http.HandlerFunc.ServeHTTP(0x11697c400?, {0x116cf4470?, 0x1400123c480?}, 0x11670b048?)
[API]          	/nix/store/79z3m4iw5y7sj5mk4w7rs37vzlian9dj-go-1.20/share/go/src/net/http/server.go:2122 +0x38
[API]          github.com/go-chi/chi/v5.(*Mux).routeHTTP(0x140003719e0, {0x116cf4470, 0x1400123c480}, 0x140019e7d00)
[API]          	/Users/mtojek/go/pkg/mod/github.com/go-chi/chi/v5@v5.0.7/mux.go:442 +0x21c
[API]          net/http.HandlerFunc.ServeHTTP(0x14001b8ca80?, {0x116cf4470?, 0x1400123c480?}, 0x100f557c8?)

It happens when you leave a browser tab open with an old workspace that used a template that is deleted now.

@mtojek mtojek self-assigned this Mar 10, 2023
@mtojek mtojek requested review from johnstcn and mafredri March 10, 2023 11:09
@mtojek mtojek marked this pull request as ready for review March 10, 2023 11:09
@mtojek mtojek merged commit 90901ca into coder:main Mar 10, 2023
@github-actions github-actions bot locked and limited conversation to collaborators Mar 10, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@johnstcn johnstcn johnstcn approved these changes

@mafredri mafredri Awaiting requested review from mafredri

Assignees

@mtojek mtojek

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mtojek @johnstcn