Skip to content

feat: import value from legacy variable to build parameter #6556

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 20 commits into from
Mar 14, 2023
Merged

feat: import value from legacy variable to build parameter #6556

Changes from 1 commit
Commits
Show all changes
20 commits
Select commit Hold shift + click to select a range
d1bd251
fix: panic on deleted template
mtojek Mar 10, 2023
40c9ba3
Add column to database
mtojek Mar 10, 2023
49f2cc6
feat: import value from legacy variable to build parameter
mtojek Mar 10, 2023
5eaf298
fix
mtojek Mar 10, 2023
56df8df
Merge branch 'fix-panic-data-templates' into 6368-legacy-variable-name
mtojek Mar 10, 2023
c5e7816
fix
mtojek Mar 10, 2023
43f40f0
Long unit test to test the migration path
mtojek Mar 13, 2023
7bfc009
fmt
mtojek Mar 13, 2023
12143d1
docs
mtojek Mar 13, 2023
60e98a3
Update docs/templates/parameters.md
mtojek Mar 14, 2023
cc2c21c
Update docs/templates/parameters.md
mtojek Mar 14, 2023
cdb7da3
Update docs/templates/parameters.md
mtojek Mar 14, 2023
b661c00
Update docs/templates/parameters.md
mtojek Mar 14, 2023
9944705
Update docs/templates/parameters.md
mtojek Mar 14, 2023
f7ca1df
Update docs/templates/parameters.md
mtojek Mar 14, 2023
16cff46
Update docs/templates/parameters.md
mtojek Mar 14, 2023
f1f97e9
Update docs/templates/parameters.md
mtojek Mar 14, 2023
fab3da2
Update docs/templates/parameters.md
mtojek Mar 14, 2023
5a910d5
Indent
mtojek Mar 14, 2023
b89e1d7
Merge branch 'main' into 6368-legacy-variable-name
mtojek Mar 14, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fmt
  • Loading branch information
@mtojek
mtojek committed Mar 13, 2023
commit 7bfc0091c8417571e465dcdf065a52bec9f0eaa5
46 changes: 24 additions & 22 deletions coderd/workspacebuilds_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -986,19 +986,20 @@ func TestMigrateLegacyToRichParameters(t *testing.T) {
Parse: []*proto.Parse_Response{{
Type: &proto.Parse_Response_Complete{
Complete: &proto.Parse_Complete{
ParameterSchemas: []*proto.ParameterSchema{{
AllowOverrideSource: true,
Name: "example",
Description: "description 1",
DefaultSource: &proto.ParameterSource{
Scheme: proto.ParameterSource_DATA,
Value: "tomato",
},
DefaultDestination: &proto.ParameterDestination{
Scheme: proto.ParameterDestination_PROVISIONER_VARIABLE,
ParameterSchemas: []*proto.ParameterSchema{
{
AllowOverrideSource: true,
Name: "example",
Description: "description 1",
DefaultSource: &proto.ParameterSource{
Scheme: proto.ParameterSource_DATA,
Value: "tomato",
},
DefaultDestination: &proto.ParameterDestination{
Scheme: proto.ParameterDestination_PROVISIONER_VARIABLE,
},
},
},
},
},
},
}},
Expand Down Expand Up @@ -1027,19 +1028,20 @@ func TestMigrateLegacyToRichParameters(t *testing.T) {
Parse: []*proto.Parse_Response{{
Type: &proto.Parse_Response_Complete{
Complete: &proto.Parse_Complete{
ParameterSchemas: []*proto.ParameterSchema{{
AllowOverrideSource: true,
Name: "example",
Description: "description 1",
DefaultSource: &proto.ParameterSource{
Scheme: proto.ParameterSource_DATA,
Value: "tomato",
},
DefaultDestination: &proto.ParameterDestination{
Scheme: proto.ParameterDestination_PROVISIONER_VARIABLE,
ParameterSchemas: []*proto.ParameterSchema{
{
AllowOverrideSource: true,
Name: "example",
Description: "description 1",
DefaultSource: &proto.ParameterSource{
Scheme: proto.ParameterSource_DATA,
Value: "tomato",
},
DefaultDestination: &proto.ParameterDestination{
Scheme: proto.ParameterDestination_PROVISIONER_VARIABLE,
},
},
},
},
},
},
}},
Expand Down