Skip to content

chore(helm): add unit tests for helm chart #6557

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 20 commits into from
Mar 13, 2023
Merged

chore(helm): add unit tests for helm chart #6557

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
20 commits
Select commit Hold shift + click to select a range
0fe5bfd
chore(helm): add unit tests for helm chart
johnstcn Mar 10, 2023
290fe48
fixup! chore(helm): add unit tests for helm chart
johnstcn Mar 10, 2023
056d54a
undo unnecessary changes to go.mod and go.sum
johnstcn Mar 10, 2023
3f10c15
fix typo
johnstcn Mar 10, 2023
74a1d2e
fixup! undo unnecessary changes to go.mod and go.sum
johnstcn Mar 10, 2023
546e4be
refactor to use golden files
johnstcn Mar 10, 2023
379aadf
rename files
johnstcn Mar 10, 2023
65f1ca6
make fmt
johnstcn Mar 10, 2023
943bcac
lint, rename file
johnstcn Mar 10, 2023
e9c91da
fix test on windows
johnstcn Mar 10, 2023
c5502cd
integrate with make update-golden-files
johnstcn Mar 10, 2023
21cd245
fixup! integrate with make update-golden-files
johnstcn Mar 10, 2023
db14e21
fixup! integrate with make update-golden-files
johnstcn Mar 10, 2023
b7a9dee
rewrite to just use helm template
johnstcn Mar 13, 2023
a015faa
revert changes to go.mod and go.sum
johnstcn Mar 13, 2023
e2fda70
skip helm tests in CI on macos/windows runners
johnstcn Mar 13, 2023
be3eacd
make fmt
johnstcn Mar 13, 2023
27543e6
set namespace explicitly
johnstcn Mar 13, 2023
31e97b2
add kubernetes-helm to nix env
johnstcn Mar 13, 2023
8f638ae
generate values and golden filenames from test name instead
johnstcn Mar 13, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fixup! integrate with make update-golden-files
  • Loading branch information
@johnstcn
johnstcn committed Mar 10, 2023
commit 21cd245e9c1984cc58f01b74bb154e0578aade6e
4 changes: 2 additions & 2 deletions Makefile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -516,14 +516,14 @@ coderd/apidoc/swagger.json: $(shell find ./scripts/apidocgen $(FIND_EXCLUSIONS)
./scripts/apidocgen/generate.sh
yarn run --cwd=site format:write:only ../docs/api ../docs/manifest.json ../coderd/apidoc/swagger.json

update-golden-files: cli/testdata/.gen-golden helm/test/testdata/.gen-golden
update-golden-files: cli/testdata/.gen-golden helm/tests/testdata/.gen-golden
.PHONY: update-golden-files

cli/testdata/.gen-golden: $(wildcard cli/testdata/*.golden) $(GO_SRC_FILES)
go test ./cli -run=TestCommandHelp -update
touch "$@"

helm/test/testdata/.gen-golden: $(wildcard helm/test/testdata/*.golden) $(GO_SRC_FILES)
helm/tests/testdata/.gen-golden: $(wildcard helm/tests/testdata/*.golden) $(GO_SRC_FILES)
go test ./helm/tests -run=TestUpdateGoldenFiles -update
touch "$@"

Expand Down
2 changes: 0 additions & 2 deletions helm/tests/chart_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -93,8 +93,6 @@ func TestUpdateGoldenFiles(t *testing.T) {
require.NoError(t, writeGoldenFile(tc.name, manifests), "failed to write golden file")
}
t.Log("Golden files updated. Please review the changes and commit them.")
t.Log("This test fails intentionally to prevent accidental updates.")
t.FailNow()
}

func TestMain(m *testing.M) {
Expand Down