Skip to content

fix: ensure local derp uses the hostname #6559

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 10, 2023
Merged

fix: ensure local derp uses the hostname #6559

merged 1 commit into from
Mar 10, 2023

Conversation

kylecarbs
Copy link
Member

This broke deployments that use a custom port with an access URL. We should write a test for this!

@kylecarbs
fix: ensure local derp uses the hostname
455fa6e 
This broke deployments that use a custom port with an access
URL. We should write a test for this!
@kylecarbs kylecarbs requested a review from mafredri March 10, 2023 15:44
@kylecarbs kylecarbs self-assigned this Mar 10, 2023
@kylecarbs kylecarbs marked this pull request as ready for review March 10, 2023 15:44
@kylecarbs kylecarbs merged commit 4a07fcd into main Mar 10, 2023
@kylecarbs kylecarbs deleted the derphost branch March 10, 2023 15:58
@github-actions github-actions bot locked and limited conversation to collaborators Mar 10, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@mafredri mafredri mafredri approved these changes

Assignees

@kylecarbs kylecarbs

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kylecarbs @mafredri