feat: allow DERP headers to be set #6572
Conversation
|
CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅ |
|
I have read the CLA Document and I hereby sign the CLA |
|
recheck |
|
@JoshVee can we make it always use the global HTTP headers instead? I'd rather not add a new top-level flag specifically for DERP. |
|
Thanks @kylecarbs. I've made the relevant changes. |
|
recheck |
|
Hi @kylecarbs, |
|
@JoshVee certainly! |
Edit, just saw your comment: coder/tailscale#12 (comment) |
|
@JoshVee doing a release today that will include this. I'm going to make a few minor changes on your branch if that's alright! |
dcf5d50 to
aa99c6c
Compare
| for k, v := range h.headers { | ||
| req.Header.Add(k, v) | ||
| for k, v := range h.header { | ||
| for _, vv := range v { |
There was a problem hiding this comment.
Oh, noticed we don't seem to handle the multi-value when first parsing the headers. Should we?
There was a problem hiding this comment.
We probably should, but feels like it's not super hard to add in the future anyhow.
codersdk/workspaceagents.go
Outdated
| Header() http.Header | ||
| }) | ||
| if ok { | ||
| header = headerTransport.Header().Clone() |
There was a problem hiding this comment.
(Accidentally deleted this comment): We seem to clone in both the function and here, not an issue per-se just pointing it out.
aa99c6c to
b543213
Compare
This PR adds the ability to set custom HTTP headers to be passed to the Tailscale connection. This allows the websocket-based DERP connection to function behind reverse proxies or tunnels (for example, authentication headers).
The DERP header functionality is controlled via the existing
--headerCLI flags.This functionality utilizes the changes introduced in the following PRs: