docs: Add more info about slow tests in the FE #6584
Conversation
BrunoQuaresma
commented
Mar 13, 2023
| ```tsx | ||
| const form = screen.getByTestId("form") | ||
| user.click(within(form).getByRole("button")) | ||
| ``` |
There was a problem hiding this comment.
I am a bit surprised to see this section in our README instead of in our wiki; however, I'm not opposed to having it here. I'm curious how this section would scale - I imagine there are all sorts of testing strategies and pitfalls we could elaborate on; which ones will we deem important enough to stick in our README? Should we eventually have an externally-facing wiki? Should we just link to a list of SO articles and Kent C Dodd's blogs we find insightful? Just some food for thought. I really appreciate the clarity of the writeup!
There was a problem hiding this comment.
It is better to have things on docs as markdown so it is also added to the website docs improving SEO as a side effect.
| - https://stackoverflow.com/questions/69711888/react-testing-library-getbyrole-is-performing-extremely-slowly | ||
| - https://github.com/testing-library/dom-testing-library/issues/552#issuecomment-625172052 | ||
|
|
||
| Even with `ByRole` having performance issues we still want to use it but for that, we have to scope the "querying" area by using the `within` command. So instead of using `screen.getByRole("button")` directly we could do `within(form).getByRole("button")`. |
There was a problem hiding this comment.
| Even with `ByRole` having performance issues we still want to use it but for that, we have to scope the "querying" area by using the `within` command. So instead of using `screen.getByRole("button")` directly we could do `within(form).getByRole("button")`. | |
| Despite its performance issues, `ByRole` is still a valuable selector. When using it, we should scope the "querying" area by using the `within` command. So instead of using `screen.getByRole("button")` directly we could do `within(form).getByRole("button")`. |