Skip to content

feat(site): Ask for parameter values when update a workspace #6586

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 10 commits into from
Mar 14, 2023
Merged

feat(site): Ask for parameter values when update a workspace #6586

merged 10 commits into from
Mar 14, 2023

Conversation

BrunoQuaresma
Copy link
Collaborator

Demo:

Screen.Recording.2023-03-13.at.14.51.10.mov

Closes #6100

@BrunoQuaresma BrunoQuaresma requested review from mtojek and a team March 13, 2023 17:55
@BrunoQuaresma BrunoQuaresma self-assigned this Mar 13, 2023
@BrunoQuaresma BrunoQuaresma requested review from code-asher and removed request for a team March 13, 2023 17:55
mtojek
mtojek approved these changes Mar 14, 2023
View reviewed changes
Copy link
Member

@mtojek mtojek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewing your PRs always brings educational value to you. Thanks!

I left one nitpick and raised one question, but otherwise it's 👍 .

@mtojek
Copy link
Member

mtojek commented Mar 14, 2023

Oh, CI complained about:

FAIL test src/pages/WorkspacePage/WorkspacePage.test.tsx (41.707 s)
  ● WorkspacePage › after an update postWorkspaceBuild is called with the latest template active version id

    expect(jest.fn()).toBeCalledWith(...expected)

    Expected: "test-outdated-workspace", "test-template-version"

    Number of calls: 0

    Ignored nodes: comments, script, style

Run: https://github.com/coder/coder/actions/runs/4408015320/jobs/7722465954

@BrunoQuaresma BrunoQuaresma merged commit 3cf235c into main Mar 14, 2023
@BrunoQuaresma BrunoQuaresma deleted the bq/aks-missing-parameters-on-update branch March 14, 2023 16:20
@github-actions github-actions bot locked and limited conversation to collaborators Mar 14, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@mtojek mtojek mtojek approved these changes

@code-asher code-asher Awaiting requested review from code-asher code-asher was automatically assigned from coder/ts

Assignees

@BrunoQuaresma BrunoQuaresma

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Rich parameters: mark parameter required
2 participants
@BrunoQuaresma @mtojek