chore: embed build info in the html to reduce requests #6605
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This will reduce a request on every page load of Coder!
f655410 to
f84321c
Compare
BrunoQuaresma
approved these changes
Mar 14, 2023
Emyrk
reviewed
Mar 15, 2023
| try { | ||
| return JSON.parse(rawContent as string) | ||
| } catch (ex) { | ||
| // Ignore this and fetch as normal! |
There was a problem hiding this comment.
Should you put some "unknown" value here? Or at least console.Log so we know something happened?
Ah we defer to api. Got it
8036d61 to
3fcbeb2
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will reduce a request on every page load of Coder!