Skip to content

feat(site): Add workspace settings page #6612

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 9 commits into from
Mar 16, 2023
Merged

feat(site): Add workspace settings page #6612

merged 9 commits into from
Mar 16, 2023

Conversation

BrunoQuaresma
Copy link
Collaborator

Screen Shot 2023-03-15 at 12 15 02

  • This page includes workspace data + build parameter values
  • At some point, we want to add more settings to this page and refactor it to look like the user settings page
  • It also fixes some layout issues with the horizontal form

Fixes #6569
Related to #6076

@BrunoQuaresma BrunoQuaresma requested review from mtojek and a team March 15, 2023 15:16
@BrunoQuaresma BrunoQuaresma self-assigned this Mar 15, 2023
@BrunoQuaresma BrunoQuaresma requested review from Kira-Pilot and removed request for a team March 15, 2023 15:17
@BrunoQuaresma BrunoQuaresma changed the title refactor(site): Add workspace settings page feat(site): Add workspace settings page Mar 15, 2023
@BrunoQuaresma BrunoQuaresma merged commit 107ae55 into main Mar 16, 2023
@BrunoQuaresma BrunoQuaresma deleted the bq/add-workspace-settings-page branch March 16, 2023 14:00
@github-actions github-actions bot locked and limited conversation to collaborators Mar 16, 2023
mtojek
mtojek reviewed Mar 16, 2023
View reviewed changes
Copy link
Member

@mtojek mtojek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

post-merge approval 👍

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@mtojek mtojek mtojek left review comments

@Kira-Pilot Kira-Pilot Kira-Pilot approved these changes

Assignees

@BrunoQuaresma BrunoQuaresma

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

site: do not show immutable parameters on build-parameters page.
3 participants
@BrunoQuaresma @mtojek @Kira-Pilot