Skip to content

feat: use app tickets for web terminal #6628

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Mar 30, 2023
Merged

feat: use app tickets for web terminal #6628

merged 5 commits into from
Mar 30, 2023

Conversation

deansheather
Copy link
Member

@deansheather deansheather commented Mar 16, 2023 •
edited
Loading

TODO:

  • bring back agent status check
  • check that app healthchecks still work???
  • remove middleware from the pty route
  • fix auth check for terminal access to be execution instead of app connect

@deansheather deansheather requested a review from Emyrk March 16, 2023 04:51
@deansheather deansheather marked this pull request as ready for review March 22, 2023 15:28
Emyrk
Emyrk reviewed Mar 22, 2023
View reviewed changes
@deansheather deansheather requested a review from Emyrk March 28, 2023 18:22
@deansheather deansheather merged commit 665b84d into main Mar 30, 2023
@deansheather deansheather deleted the dean/tickets-for-web-terminal branch March 30, 2023 13:24
@github-actions github-actions bot locked and limited conversation to collaborators Mar 30, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@Emyrk Emyrk Emyrk approved these changes

Assignees

@deansheather deansheather

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@deansheather @Emyrk