feat: CLI use multiselect for list(string) #6631
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Back to draft, spotted a bug |
mafredri
approved these changes
Mar 16, 2023
| @@ -118,6 +133,29 @@ func Select(cmd *cobra.Command, opts SelectOptions) (string, error) { | |||
| return value, err | |||
| } | |||
|
|
|||
| func MultiSelect(cmd *cobra.Command, items []string) ([]string, error) { | |||
| // Similar hack is applied to Select() | |||
| if flag.Lookup("test.v") != nil { | |||
There was a problem hiding this comment.
Hmm, so it looks like we're not actually testing the multi select behavior with this hack?
There was a problem hiding this comment.
Yes, I was surprised about it too, it just goes with the default. I wasn't able to properly simulate the user marking options.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related: #6582
This PR enables support for multiselect in CLI, so that
codercan render rich parameter typelist(string).