Skip to content

chore: Typescript generator TODOs resolved, adding explainations #6633

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Mar 17, 2023
Merged

chore: Typescript generator TODOs resolved, adding explainations #6633

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
0ba9c0e
chore: Explain usage of eslint comments
Emyrk Mar 16, 2023
fa17a61
Conform comment
Emyrk Mar 16, 2023
95be24f
Fix wording
Emyrk Mar 16, 2023
bc824c5
Linting
Emyrk Mar 16, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Conform comment
  • Loading branch information
@Emyrk
Emyrk committed Mar 16, 2023
commit fa17a613115012ea399972baa0f4be87c1f0dc5f
3 changes: 1 addition & 2 deletions scripts/apitypings/main.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -645,8 +645,7 @@ func (g *Generator) typescriptType(ty types.Type) (TypescriptType, error) {
ValueType: "any",
AboveTypeLine: fmt.Sprintf("%s\n%s",
indentedComment("Embedded anonymous struct, please fix by naming it"),
// Must include an eslint exception, otherwise the typescript linter will complain about
// the usage of an "any" type.
// Linter needs to be disabled here, or else it will complain about the "any" type.
indentedComment("eslint-disable-next-line @typescript-eslint/no-explicit-any"),
),
}, nil
Expand Down