Skip to content

chore: regenerate helm golden tests #6642

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 17, 2023
Merged

chore: regenerate helm golden tests #6642

merged 1 commit into from
Mar 17, 2023

Conversation

deansheather
Copy link
Member

#6432 was opened before the Helm tests were added, and so tests passed and the PR was merged without updating the golden files.

@deansheather deansheather requested a review from johnstcn March 17, 2023 04:48
johnstcn
johnstcn approved these changes Mar 17, 2023
View reviewed changes
Copy link
Member

@johnstcn johnstcn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@mtojek
Copy link
Member

mtojek commented Mar 17, 2023

Let me merge this as it impacts PRs.

@mtojek mtojek merged commit 446bd30 into main Mar 17, 2023
@mtojek mtojek deleted the dean/regen-helm-tests branch March 17, 2023 11:56
@github-actions github-actions bot locked and limited conversation to collaborators Mar 17, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@johnstcn johnstcn johnstcn approved these changes

Assignees

@deansheather deansheather

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@deansheather @mtojek @johnstcn