feat: show Terraform error details #6643
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mafredri
approved these changes
Mar 17, 2023
| @@ -509,7 +512,7 @@ func convertTerraformLogLevel(logLevel string, sink logSink) proto.LogLevel { | |||
| return proto.LogLevel_DEBUG | |||
| case "info": | |||
| return proto.LogLevel_INFO | |||
| case "warn": | |||
| case "warn", "warning": | |||
There was a problem hiding this comment.
I spotted in the original Terraform code that it has references to "warning". Maybe some Terraform versions or plugins use a different label?
| for _, value := range values { | ||
| _, _ = fmt.Fprintf(buf, " │ %s %s\n", value.Traversal, value.Statement) | ||
| } | ||
| } |
There was a problem hiding this comment.
It seemed like the original (internal) code is slightly more complex, do we lose any details in error output or are they surfaced some other way? It looked like function calls/args were handled in internal, but not here.
There was a problem hiding this comment.
Yes, as these are not exposed by terraform-json. I think that we can live without those until any user requests them.
bpmct
approved these changes
Mar 18, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves: #6453
This PR enables Terraform diagnostics details in the site view and CLI. Unfortunately, the original formatter is in the
internalpackage, so I had to implement a similar one.