Skip to content

feat(audit): auditing token addition and removal #6649

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Mar 17, 2023
Merged

feat(audit): auditing token addition and removal #6649

merged 5 commits into from
Mar 17, 2023

Conversation

Kira-Pilot
Copy link
Member

resolves #4519
Screenshot 2023-03-16 at 5 07 05 PM

@Kira-Pilot Kira-Pilot requested a review from coadler March 17, 2023 14:53
@Kira-Pilot Kira-Pilot requested a review from Emyrk March 17, 2023 14:53
Emyrk
Emyrk approved these changes Mar 17, 2023
View reviewed changes
Copy link
Member

@Emyrk Emyrk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should really consider adding something to dbauthz to force these audit logs. Too easy to miss spots.

@Kira-Pilot Kira-Pilot merged commit 090e37f into main Mar 17, 2023
@Kira-Pilot Kira-Pilot deleted the audit-tokens/kira-pilot branch March 17, 2023 17:41
@github-actions github-actions bot locked and limited conversation to collaborators Mar 17, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@Emyrk Emyrk Emyrk approved these changes

@coadler coadler Awaiting requested review from coadler

Assignees

@Kira-Pilot Kira-Pilot

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

audit: add events for API token creation
2 participants
@Kira-Pilot @Emyrk