feat: Dbauthz is now default, remove out of experimental #6650
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Emyrk
commented
Mar 17, 2023
Comment on lines
+39
to
+41
| client, _, api := coderdtest.NewWithAPI(t, &coderdtest.Options{IncludeProvisionerDaemon: true}) | ||
| user := coderdtest.CreateFirstUser(t, client) | ||
| authz := coderdtest.AssertRBAC(t, api, client) |
There was a problem hiding this comment.
See this unit test to see how to asset an rbac action was checked.
This is a very basic check on 1 GET, but shows how you can assert certain rbac checks are run with the given client as the subject.
There was a problem hiding this comment.
This is a nice feature to have, but given that it essentially duplicates what we already codify in our authz_querier, we should probably use it sparingly.
johnstcn
requested changes
Mar 20, 2023
johnstcn
reviewed
Mar 20, 2023
johnstcn
reviewed
Mar 20, 2023
johnstcn
reviewed
Mar 20, 2023
johnstcn
reviewed
Mar 20, 2023
johnstcn
reviewed
Mar 20, 2023
johnstcn
reviewed
Mar 20, 2023
| // RBACAsserter is a helper for asserting that the correct RBAC checks are | ||
| // performed. This struct is tied to a given user, and only authorizes calls | ||
| // for this user are checked. | ||
| type RBACAsserter struct { |
There was a problem hiding this comment.
This is really nice to have integrated into coderdtest.
johnstcn
reviewed
Mar 20, 2023
There is a unit test already 👍 |
johnstcn
reviewed
Mar 20, 2023
johnstcn
reviewed
Mar 20, 2023
coderd/coderdtest/authorize.go
Outdated
Comment on lines
270
to
283
| func caller(skip int) string { | ||
| pc, file, line, ok := runtime.Caller(skip + 1) | ||
| i := strings.Index(file, "coder") | ||
| if i >= 0 { | ||
| file = file[i:] | ||
| } | ||
| str := fmt.Sprintf("%s:%d", file, line) | ||
| if ok { | ||
| f := runtime.FuncForPC(pc) | ||
| filepath.Base(f.Name()) | ||
| str += " | " + filepath.Base(f.Name()) | ||
| } | ||
| return str | ||
| } |
johnstcn
approved these changes
Mar 20, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this does
Almost all RBAC checks happen in dbauthz layer now.
Unit tests
I removed
AuthorizeAllEndpoints, it was flawed anyway.A new method of doing rbac assertions was added if you want to check this in a route test. This is no longer required though as
dbauthzenforces rbac checks. This exists for edge cases or debugging. Tests are optional similar to how we check audit log entries.