Skip to content

docs: add k8s & aws to offline Dockerfile #6663

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 20, 2023
Merged

docs: add k8s & aws to offline Dockerfile #6663

merged 1 commit into from
Mar 20, 2023

Conversation

ericpaulsen
Copy link
Member

adds the K8s & AWS terraform provider installs into the offline Dockerfile example.

@ericpaulsen ericpaulsen added the docs Area: coder.com/docs label Mar 19, 2023
@ericpaulsen ericpaulsen requested review from sharkymark and bpmct March 19, 2023 21:43
@ericpaulsen ericpaulsen self-assigned this Mar 19, 2023
bpmct
bpmct reviewed Mar 19, 2023
View reviewed changes
Copy link
Member

@bpmct bpmct left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Has this been tested in an offline environment, or does it still need testing?

@ericpaulsen
Copy link
Member Author

LGTM. Has this been tested in an offline environment, or does it still need testing?

did not test in an offline environment but did test initializing terraform and creating templates.

@bpmct bpmct merged commit fadeb2b into main Mar 20, 2023
@bpmct bpmct deleted the offline-k8s-provider branch March 20, 2023 08:47
@github-actions github-actions bot locked and limited conversation to collaborators Mar 20, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@bpmct bpmct bpmct approved these changes

@sharkymark sharkymark Awaiting requested review from sharkymark

Assignees

@ericpaulsen ericpaulsen

Labels
docs Area: coder.com/docs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ericpaulsen @bpmct