Skip to content

fix: dbauthz: fix RBAC call for GetTemplateVersionVariables #6670

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 20, 2023
Merged

fix: dbauthz: fix RBAC call for GetTemplateVersionVariables #6670

merged 1 commit into from
Mar 20, 2023

Conversation

johnstcn
Copy link
Member

In GetTemplateVersionVariables we were effectively asking the provisionerd role to call rbac.ActionCreate on rbac.ResourceTemplate, which will never work. Updated this to be rbac.ActionRead instead.

Also, noting that the provisionerd role currently has read, update on ResourceTemplate.

@johnstcn johnstcn self-assigned this Mar 20, 2023
@johnstcn johnstcn requested review from mtojek and Emyrk March 20, 2023 10:05
@johnstcn johnstcn mentioned this pull request Mar 20, 2023
Closed
@johnstcn johnstcn changed the title bug: dbauthz: fix RBAC call for GetTemplateVersionVariables fix/experimental: dbauthz: fix RBAC call for GetTemplateVersionVariables Mar 20, 2023
mtojek
mtojek approved these changes Mar 20, 2023
View reviewed changes
Copy link
Member

@mtojek mtojek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@johnstcn johnstcn changed the title fix/experimental: dbauthz: fix RBAC call for GetTemplateVersionVariables fix: dbauthz: fix RBAC call for GetTemplateVersionVariables Mar 20, 2023
@johnstcn johnstcn merged commit 331a49b into main Mar 20, 2023
@johnstcn johnstcn deleted the cj/dbauthz-get-template-version-variable branch March 20, 2023 10:22
@github-actions github-actions bot locked and limited conversation to collaborators Mar 20, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@mtojek mtojek mtojek approved these changes

@Emyrk Emyrk Awaiting requested review from Emyrk

Assignees

@johnstcn johnstcn

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@johnstcn @mtojek