Skip to content

chore: Return copied templates to prevent reference issues #6679

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 20, 2023

Conversation

Emyrk
Copy link
Member

@Emyrk Emyrk commented Mar 20, 2023

Returning template from the underlying slice allows the external caller to modify the ACL fields by reference.

@Emyrk Emyrk requested a review from johnstcn March 20, 2023 17:08
@Emyrk Emyrk merged commit 65945ae into main Mar 20, 2023
@Emyrk Emyrk deleted the stevenmasley/deep_copy_tpls branch March 20, 2023 18:13
@github-actions github-actions bot locked and limited conversation to collaborators Mar 20, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants