Skip to content

feat(site): Add source code tab on template page, group buttons and add edit file option #6681

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 9 commits into from
Mar 21, 2023

Conversation

BrunoQuaresma
Copy link
Collaborator

Closes #6119

Demo:

Screen.Recording.2023-03-20.at.15.48.55.mov

@BrunoQuaresma BrunoQuaresma requested review from bpmct and a team March 20, 2023 18:51
@BrunoQuaresma BrunoQuaresma self-assigned this Mar 20, 2023
@BrunoQuaresma BrunoQuaresma requested review from Kira-Pilot and removed request for a team March 20, 2023 18:51
Copy link
Member

@bpmct bpmct left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Love it! Thoughts on showing the current version name in the source code tab and a link to see all versions so a user could quickly switch?

@matifali
Copy link
Member

Personally, The buttons looked better and more accessible to me.

@BrunoQuaresma
Copy link
Collaborator Author

@matifali yes, but it does not scale very well for now. I will try to group some of these features and see if by reducing the number of actions on the header, we can display them again.

@BrunoQuaresma
Copy link
Collaborator Author

@bpmct right now, the summary displays all the versions but they are lazy loaded so "fragment" links will not work properly. Is it ok we merge this as it is and we can create an issue with the feature that you suggested? I think it is pretty good tho.

Copy link
Member

@Kira-Pilot Kira-Pilot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice work!

@BrunoQuaresma BrunoQuaresma enabled auto-merge (squash) March 21, 2023 16:42
@BrunoQuaresma BrunoQuaresma merged commit 29d71bb into main Mar 21, 2023
@BrunoQuaresma BrunoQuaresma deleted the bq/show-source-code-on-template branch March 21, 2023 16:52
@github-actions github-actions bot locked and limited conversation to collaborators Mar 21, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

template editor: add "edit" button and code preview to template page, not tied to a specific version
4 participants