chore: avoid logging http.ErrAbortHandler panics #6686
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
httputil.ReverseProxywill panic withhttp.ErrAbortHandlerwhen it can't copy the response properly (source). This could be because the client closed their browser window or killed the CLI etc.This isn't a traditional panic caused by a developer error, and is unavoidable in production so we should avoid logging them.
The
err == http.ErrAbortHandlercheck is also how the recover handler built into the stdlib operates (source).chi's recovery middleware also functions the same way (source).