Skip to content

fix: Only show mutable parameters on workspace settings form #6690

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 21, 2023
Merged

fix: Only show mutable parameters on workspace settings form #6690

merged 1 commit into from
Mar 21, 2023
+1 −1

Conversation

BrunoQuaresma
Copy link
Collaborator

No description provided.

@BrunoQuaresma BrunoQuaresma requested a review from mtojek March 21, 2023 12:46
@BrunoQuaresma BrunoQuaresma self-assigned this Mar 21, 2023
mtojek
mtojek reviewed Mar 21, 2023
View reviewed changes
Copy link
Member

@mtojek mtojek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need a unit test to make sure that we're not exposing immutables?

@BrunoQuaresma
Copy link
Collaborator Author

For something like this, I think it is ok to not have tests for now. Saying that because it is not a blocker and BE will not allow users to enter in a invalid state.

@BrunoQuaresma BrunoQuaresma requested review from a team and Kira-Pilot and removed request for a team March 21, 2023 16:31
@BrunoQuaresma BrunoQuaresma enabled auto-merge (squash) March 21, 2023 16:43
@BrunoQuaresma BrunoQuaresma merged commit f97c225 into main Mar 21, 2023
@BrunoQuaresma BrunoQuaresma deleted the bq/fix-immutable-fields-on-settings branch March 21, 2023 16:47
@github-actions github-actions bot locked and limited conversation to collaborators Mar 21, 2023
@mtojek
Copy link
Member

mtojek commented Mar 21, 2023

For something like this, I think it is ok to not have tests for now. Saying that because it is not a blocker and BE will not allow users to enter in a invalid state.

👍

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@mtojek mtojek mtojek left review comments

@rodrimaia rodrimaia rodrimaia approved these changes

@Kira-Pilot Kira-Pilot Awaiting requested review from Kira-Pilot Kira-Pilot was automatically assigned from coder/ts

Assignees

@BrunoQuaresma BrunoQuaresma

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@BrunoQuaresma @mtojek @rodrimaia