Skip to content

fix: Page offset on workspace pagination was incorrect #6693

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Mar 22, 2023
Merged

fix: Page offset on workspace pagination was incorrect #6693

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
930b74b
fix: Page offset on workspace pagination was incorrect
Emyrk Mar 21, 2023
89aa6cc
Make fmt
Emyrk Mar 21, 2023
8ed7cf8
Merge remote-tracking branch 'origin/main' into stevenmasley/fix_offset
Emyrk Mar 22, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion site/src/pages/WorkspacesPage/data.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,9 @@ export const useWorkspacesData = ({
getWorkspaces({
q: query,
limit: limit,
offset: page,
// If the page is <= 0, just use offset 0. This usually happens
// if the page is not provided.
offset: page <= 0 ? 0 : (page-1)*limit ,
}),
refetchInterval: 5_000,
})
Expand Down