feat: pass access_token to coder_git_auth resource
#6713
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
d1ecc81 to
08e9d55
Compare
deansheather
approved these changes
Mar 22, 2023
| UserID: owner.ID, | ||
| }) | ||
| if errors.Is(err, sql.ErrNoRows) { | ||
| continue |
There was a problem hiding this comment.
I assumed that git auth was required if a template specifies it based on not being able to create a workspace in dogfood until I set it up. Should this not fail the build early or something?
There was a problem hiding this comment.
I think we might make this an option in the data source eventually, but the default should be to never fail builds.
This feature is mostly useful for a first-time clone anyways.
| } | ||
| // We weren't able to find a matching config for the ID! | ||
| if config == nil { | ||
| continue |
There was a problem hiding this comment.
We should probably log and/or fail the build here.
There was a problem hiding this comment.
True, I'll make it warn.
Comment on lines
19
to
20
| repeated provisioner.VariableValue variable_values = 5; | ||
| provisioner.Provision.Metadata metadata = 6; | ||
| bytes state = 7; | ||
| repeated provisioner.GitAuthProvider git_auth_providers = 6; |
There was a problem hiding this comment.
these two lines have tabs instead of 8 spaces
This allows template authors to leverage git auth to perform custom actions, like clone repositories.
08e9d55 to
54466ce
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows template authors to leverage git auth to perform custom actions, like clone repositories.
I mostly moved code around in this, there are actually very few changes. The increased lines is primarily due to hardening around refreshing the Git token, which I felt was important enough to become slightly abstracted.
This essentially enables: