Skip to content

chore: add typescript api for ssh config #6741

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Mar 23, 2023
Merged

chore: add typescript api for ssh config #6741

merged 2 commits into from
Mar 23, 2023

Conversation

Emyrk
Copy link
Member

@Emyrk Emyrk commented Mar 22, 2023 •
edited
Loading

Needed for vscode extension.

@Emyrk Emyrk requested a review from kylecarbs March 22, 2023 21:49
kylecarbs
kylecarbs approved these changes Mar 22, 2023
View reviewed changes
Copy link
Member

@kylecarbs kylecarbs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

getDeploymentSSHConfig if you wanna, I don't really care though.

Might be smart to add a comment why this is here, otherwise it could be removed as dead code

@Emyrk Emyrk enabled auto-merge (squash) March 23, 2023 17:42
@Emyrk Emyrk merged commit a6fa8ca into main Mar 23, 2023
@Emyrk Emyrk deleted the stevenmasley/ssh_config_api branch March 23, 2023 17:46
@github-actions github-actions bot locked and limited conversation to collaborators Mar 23, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@kylecarbs kylecarbs kylecarbs approved these changes

Assignees

@Emyrk Emyrk

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Emyrk @kylecarbs