Skip to content

feat: preserve original order of rich parameters #6747

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Mar 24, 2023

Conversation

mtojek
Copy link
Member

@mtojek mtojek commented Mar 23, 2023

Resolves: #6362

This PR modifies the logic responsible for processing Terraform state to ensure the real order of coder_parameters. In planResources step, the executor will inspect *.tf files one more time to check the order of parameters.

@mtojek mtojek self-assigned this Mar 23, 2023
@mtojek mtojek marked this pull request as ready for review March 23, 2023 11:45
@mtojek mtojek changed the title feat: preserve the TF file order of rich parameters feat: preserve original order of rich parameters Mar 23, 2023
@mtojek mtojek requested a review from kylecarbs March 23, 2023 11:46
Copy link
Collaborator

@BrunoQuaresma BrunoQuaresma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If they are tested, I'm good with them 👍

@mtojek mtojek merged commit c7fb5f9 into coder:main Mar 24, 2023
@github-actions github-actions bot locked and limited conversation to collaborators Mar 24, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Rich parameters: ability to specify order of fields in UI
2 participants