Skip to content

fix: Users that can update a template can also read the file #6776

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Mar 27, 2023
Merged

fix: Users that can update a template can also read the file #6776

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
3fbbaa7
fix: Users that can update a template can also read the file
Emyrk Mar 24, 2023
0b23984
Add unit test
Emyrk Mar 24, 2023
4965750
Only showsource code tab if the user has permission to edit the template
BrunoQuaresma Mar 24, 2023
175a99c
Merge remote-tracking branch 'origin/main' into stevenmasley/file_per…
Emyrk Mar 27, 2023
b11fea2
Fix unit test from merge
Emyrk Mar 27, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Only showsource code tab if the user has permission to edit the template
  • Loading branch information
@BrunoQuaresma
BrunoQuaresma committed Mar 24, 2023
commit 496575052d6079cd8519f937d1140ee1dca748e4
24 changes: 13 additions & 11 deletions site/src/components/TemplateLayout/TemplateLayout.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -110,17 +110,19 @@ export const TemplateLayout: FC<{ children?: JSX.Element }> = ({
>
Summary
</NavLink>
<NavLink
to={`/templates/${templateName}/files`}
className={({ isActive }) =>
combineClasses([
styles.tabItem,
isActive ? styles.tabItemActive : undefined,
])
}
>
Source Code
</NavLink>
{data.permissions.canUpdateTemplate && (
<NavLink
to={`/templates/${templateName}/files`}
className={({ isActive }) =>
combineClasses([
styles.tabItem,
isActive ? styles.tabItemActive : undefined,
])
}
>
Source Code
</NavLink>
)}
</Stack>
</Margins>
</div>
Expand Down