fix: permit SSH by default when startup script fails #6798
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kylecarbs
approved these changes
Mar 27, 2023
mafredri
reviewed
Mar 27, 2023
|
|
||
| // We don't want to fail on a startup script error because it's | ||
| // natural that the user will want to fix the script and try again. | ||
| // We don't print the error because cliui.Agent does that for us. |
There was a problem hiding this comment.
@ammario with this change, there'll be no indication for people SSH:ing in that there's a problem or that the workspace ran into an error (--stdio).
The logs would only be visible by doing ssh -v.
I guess one option would be to print this on the agent side, as part of MOTD.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.