Skip to content

fix: correct minor formatting issues in CLI #6813

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Mar 28, 2023
Merged

fix: correct minor formatting issues in CLI #6813

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
9bdd8e5
fix: remove excess newlines from server startup
ammario Mar 27, 2023
e8a8fb6
Don't log benign closed pipe errors
ammario Mar 27, 2023
da855c9
Merge remote-tracking branch 'origin/main' into cli-fix
ammario Mar 28, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Don't log benign closed pipe errors
  • Loading branch information
@ammario
ammario committed Mar 27, 2023
commit e8a8fb62282b482d400a60f687f9743dd97d9cc4
6 changes: 5 additions & 1 deletion coderd/workspaceagents.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -774,7 +774,11 @@ func (api *API) dialWorkspaceAgentTailnet(agentID uuid.UUID) (*codersdk.Workspac
go func() {
err := (*api.TailnetCoordinator.Load()).ServeClient(serverConn, uuid.New(), agentID)
if err != nil {
api.Logger.Warn(ctx, "tailnet coordinator client error", slog.Error(err))
// Sometimes, we get benign closed pipe errors when the server is
// shutting down.
if api.ctx.Err() == nil {
api.Logger.Warn(ctx, "tailnet coordinator client error", slog.Error(err))
}
_ = agentConn.Close()
}
}()
Expand Down