Skip to content

fix(agent): More protection for lost output of SSH PTY commands #6833

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Mar 28, 2023
Merged

fix(agent): More protection for lost output of SSH PTY commands #6833

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
bcf04ee
fix(agent): More protection for lost output of SSH PTY commands
mafredri Mar 28, 2023
1507d63
Actually skip test
mafredri Mar 28, 2023
3119d70
Actually lower iterations
mafredri Mar 28, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Actually skip test
  • Loading branch information
@mafredri
mafredri committed Mar 28, 2023
commit 1507d63f165b71a600ef353f9347489080e13d90
2 changes: 1 addition & 1 deletion agent/agent_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -410,7 +410,7 @@ func TestAgent_Session_TTY_HugeOutputIsNotLost(t *testing.T) {
// it seems like it could be either.
t.Skip("ConPTY appears to be inconsistent on Windows.")
}
// t.Skip("This test proves we have a bug where parts of large output on a PTY can be lost after the command exits, skipped to avoid test failures.")
t.Skip("This test proves we have a bug where parts of large output on a PTY can be lost after the command exits, skipped to avoid test failures.")

// This test is here to prevent prove we have a bug where quickly executing
// commands (with TTY) don't flush their output to the SSH session. This is
Expand Down