Skip to content

chore(site): Try to fix flake test #6848

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 9 commits into from
Mar 29, 2023
Merged

chore(site): Try to fix flake test #6848

Changes from 1 commit
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
2822864
Fix lint
BrunoQuaresma Mar 28, 2023
9c013a6
chore(site): Try to fix flake tests and improve quality
BrunoQuaresma Mar 28, 2023
3cc5a58
Fix stories
BrunoQuaresma Mar 28, 2023
591284d
Change mock user
BrunoQuaresma Mar 28, 2023
84c8122
Refactor mocks
BrunoQuaresma Mar 28, 2023
b72c9dd
Fix imports
BrunoQuaresma Mar 28, 2023
3f41738
Fix imports
BrunoQuaresma Mar 28, 2023
6ce23a4
Fix i18n on storybook
BrunoQuaresma Mar 29, 2023
a237784
Update comment
BrunoQuaresma Mar 29, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Update comment
  • Loading branch information
@BrunoQuaresma
BrunoQuaresma committed Mar 29, 2023
commit a23778472dc84918850a513377d83f90a043e195
7 changes: 4 additions & 3 deletions site/.eslintrc.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,9 +37,10 @@ overrides:
- files: ["**/__tests__/**/*.[jt]s?(x)", "**/?(*.)+(spec|test).[jt]s?(x)"]
extends: ["plugin:testing-library/react", "plugin:testing-library/dom"]
rules:
# These rules are disabled because they can degrade test speed a bit since
# sometimes we need to access the directly in a lower scope to prevent the
# library to fetch a bunch of element
# Occasionally, we must traverse the DOM when querying for an element to
# avoid the performance costs that come with using selectors like ByRole.
# You can read more about these performance costs here:
# https://coder.com/docs/v2/latest/contributing/frontend#tests-getting-too-slow.
testing-library/no-node-access: off
testing-library/no-container: off
root: true
Expand Down