Skip to content

fix(agent): Close stdin and stdout separately to fix pty output loss #6862

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Mar 29, 2023
Merged

fix(agent): Close stdin and stdout separately to fix pty output loss #6862

merged 2 commits into from
Mar 29, 2023

Conversation

mafredri
Copy link
Member

Fixes #6656
Closes #6840

@mafredri mafredri force-pushed the mafredri/fix-ssh-pty-output-loss-part3 branch from 010f111 to 40377be Compare March 29, 2023 10:28
@mafredri mafredri force-pushed the mafredri/fix-ssh-pty-output-loss-part3 branch from 40377be to 197bedc Compare March 29, 2023 10:33
mafredri
mafredri commented Mar 29, 2023
View reviewed changes
agent/agent_test.go
// This might be our implementation, or ConPTY itself.
// It's difficult to find extensive tests for it, so
// it seems like it could be either.
t.Skip("ConPTY appears to be inconsistent on Windows.")
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This might be risky (flakey CI), but maybe we should see if it's a problem on Windows?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agreed!

@mafredri mafredri marked this pull request as ready for review March 29, 2023 10:58
@mafredri mafredri requested review from kylecarbs and mtojek March 29, 2023 10:58
mtojek
mtojek approved these changes Mar 29, 2023
View reviewed changes
Copy link
Member

@mtojek mtojek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM stamp, but I didn't test it.

@bpmct bpmct mentioned this pull request Mar 29, 2023
Closed
1 task
@mafredri mafredri mentioned this pull request Mar 29, 2023
Closed
@mafredri mafredri merged commit 90d18dd into main Mar 29, 2023
@mafredri mafredri deleted the mafredri/fix-ssh-pty-output-loss-part3 branch March 29, 2023 18:58
@github-actions github-actions bot locked and limited conversation to collaborators Mar 29, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@kylecarbs kylecarbs kylecarbs approved these changes

@mtojek mtojek mtojek approved these changes

Assignees

@mafredri mafredri

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Running commands over ssh -t periodically gives no output
3 participants
@mafredri @kylecarbs @mtojek