feat(site): display template's readme first on template page #6863
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅ |
|
I have read the CLA Document and I hereby sign the CLA |
|
recheck |
cdrcommunity
added a commit
to coder/cla
that referenced
this pull request
Mar 29, 2023
|
Thoughts on DAU still coming first? Because README hasn't been near the top, users may not have actually filled it out. Maybe we ask for some feedback in Discord. |
|
I think asking this in Discord is a good one. |
|
@rodrimaia I think we can move the chart to be the first element on the screen. |
BrunoQuaresma
approved these changes
Mar 30, 2023
@BrunoQuaresma sorry Bruno, asking for a new review since we changed the scope of this PR |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
~~This pull request moves the Readme section on the template page to appear first, replacing its previous position after the DAU and Template Resources sections.
We decided to not limit the readme section height for now. Another idea would be to have the option to collapse the section if we realize templates readme tend to be big ~~
We decided to have a new Docs tab with the Readme. We created also a redirect to point bookmarked links of /templateName#readme to the new tab!
Loom video:
https://www.loom.com/share/3c83e8e528d744b1afb8fb8b049f8017