Skip to content

feat: allow configuring OIDC email claim and OIDC auth url parameters #6867

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
Mar 30, 2023
Merged

feat: allow configuring OIDC email claim and OIDC auth url parameters #6867

merged 7 commits into from
Mar 30, 2023

Conversation

johnstcn
Copy link
Member

@johnstcn johnstcn commented Mar 29, 2023 •
edited
Loading

This commit:

  • Allows configuring the OIDC claim Coder uses for email addresses (by default, this is still email)
  • Allows customising the parameters sent to the upstream identity provider when requesting a token. This is still access_type=offline by default.
  • Updates documentation related to the above.

If you need to poke around in a testing environment with OIDC configured, reach out to me and I can set you up.

@johnstcn johnstcn self-assigned this Mar 29, 2023
@johnstcn johnstcn requested review from mafredri and coadler March 29, 2023 20:42
@johnstcn johnstcn marked this pull request as ready for review March 29, 2023 20:42
@johnstcn johnstcn merged commit 563c3ad into main Mar 30, 2023
@johnstcn johnstcn deleted the cj/oidc-auth-url-params branch March 30, 2023 08:37
@github-actions github-actions bot locked and limited conversation to collaborators Mar 30, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@coadler coadler coadler approved these changes

@mafredri mafredri Awaiting requested review from mafredri

Assignees

@johnstcn johnstcn

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@johnstcn @coadler