Skip to content

fix(site): fix redirection to login after logout/change password #6870

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Mar 29, 2023
Merged

fix(site): fix redirection to login after logout/change password #6870

merged 5 commits into from
Mar 29, 2023

Conversation

rodrimaia
Copy link
Contributor

@rodrimaia rodrimaia commented Mar 29, 2023 •
edited
Loading

Fix: #6133 and #6783

In this pull request, we have addressed an issue where the user was not being redirected to the login page after logging out or changing their password. We have made the following changes:

  1. Updated the logout function to ensure proper redirection to the login page.
  2. Modified the password change success handling to direct the user to the login page.

Tests

  • Edit the security page integration test to check if the login page is being displayed after changing the password
  • Created a e2e test handling logout

@rodrimaia rodrimaia requested review from a team and BrunoQuaresma and removed request for a team March 29, 2023 18:17
BrunoQuaresma
BrunoQuaresma approved these changes Mar 29, 2023
View reviewed changes
Copy link
Collaborator

@BrunoQuaresma BrunoQuaresma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a minor thing if you think it is necessary.

@rodrimaia rodrimaia enabled auto-merge (squash) March 29, 2023 20:29
@rodrimaia rodrimaia disabled auto-merge March 29, 2023 20:29
@rodrimaia rodrimaia enabled auto-merge (squash) March 29, 2023 20:29
@rodrimaia rodrimaia force-pushed the fix_user_not_being_redirected_to_login_after_logout branch from d149f71 to dbca115 Compare March 29, 2023 21:25
@rodrimaia rodrimaia merged commit 3d91fe8 into main Mar 29, 2023
@rodrimaia rodrimaia deleted the fix_user_not_being_redirected_to_login_after_logout branch March 29, 2023 21:39
@github-actions github-actions bot locked and limited conversation to collaborators Mar 29, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@BrunoQuaresma BrunoQuaresma BrunoQuaresma approved these changes

Assignees

@rodrimaia rodrimaia

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

bug: ui: user not redirected to sign in after API key invalidated
2 participants
@rodrimaia @BrunoQuaresma