Skip to content

chore(UI): remove template link from workspaces page row #6882

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 30, 2023
Merged

chore(UI): remove template link from workspaces page row #6882

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
93805b6
chore(UI): remove template link from workspaces page row
Kira-Pilot Mar 30, 2023
348c4ed
remove stack and span as per PR comment
Kira-Pilot Mar 30, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
35 changes: 2 additions & 33 deletions site/src/components/WorkspacesTable/WorkspacesRow.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,15 +5,13 @@ import KeyboardArrowRight from "@material-ui/icons/KeyboardArrowRight"
import { AvatarData } from "components/AvatarData/AvatarData"
import { WorkspaceStatusBadge } from "components/WorkspaceStatusBadge/WorkspaceStatusBadge"
import { FC } from "react"
import { useNavigate, Link as RouterLink } from "react-router-dom"
import { useNavigate } from "react-router-dom"
import { getDisplayWorkspaceTemplateName } from "util/workspace"
import { LastUsed } from "../LastUsed/LastUsed"
import { Workspace } from "api/typesGenerated"
import { OutdatedHelpTooltip } from "components/Tooltips/OutdatedHelpTooltip"
import { Avatar } from "components/Avatar/Avatar"
import { Stack } from "components/Stack/Stack"
import TemplateLinkIcon from "@material-ui/icons/OpenInNewOutlined"
import Link from "@material-ui/core/Link"
import { useClickableTableRow } from "hooks/useClickableTableRow"

export const WorkspacesRow: FC<{
Expand Down Expand Up @@ -57,22 +55,7 @@ export const WorkspacesRow: FC<{
/>
</TableCell>

<TableCell>
<Link
component={RouterLink}
to={`/templates/${workspace.template_name}`}
className={styles.templateLink}
title={`Go to ${displayTemplateName} page`}
onClick={(e) => {
e.stopPropagation()
}}
>
<Stack direction="row" alignItems="center" spacing={1}>
<TemplateLinkIcon className={styles.templateLinkIcon} />
<span>{displayTemplateName}</span>
</Stack>
</Link>
</TableCell>
<TableCell>{displayTemplateName}</TableCell>

<TableCell>
<LastUsed lastUsedAt={workspace.last_used_at} />
Expand Down Expand Up @@ -102,18 +85,4 @@ const useStyles = makeStyles((theme) => ({
display: "flex",
paddingLeft: theme.spacing(2),
},

templateLink: {
color: theme.palette.text.secondary,

"&:hover": {
color: theme.palette.text.primary,
textDecoration: "none",
},
},

templateLinkIcon: {
width: theme.spacing(1.5),
height: theme.spacing(1.5),
},
}))