Skip to content

chore: move away from set-output in GitHub Actions #6884

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 30, 2023
Merged

chore: move away from set-output in GitHub Actions #6884

merged 1 commit into from
Mar 30, 2023

Conversation

kylecarbs
Copy link
Member

@kylecarbs kylecarbs requested a review from deansheather March 30, 2023 14:10
@kylecarbs kylecarbs self-assigned this Mar 30, 2023
deansheather
deansheather requested changes Mar 30, 2023
View reviewed changes
Copy link
Member

@deansheather deansheather left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does not work on Windows I already tried this :(

@deansheather
Copy link
Member

Could duplicate this task and use if based on matrix OS

deansheather
deansheather approved these changes Mar 30, 2023
View reviewed changes
Copy link
Member

@deansheather deansheather left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if it passes LGTM!

@kylecarbs
Copy link
Member Author

@deansheather merge if fail

@kylecarbs kylecarbs merged commit e470162 into main Mar 30, 2023
@kylecarbs kylecarbs deleted the depoutput branch March 30, 2023 14:58
@github-actions github-actions bot locked and limited conversation to collaborators Mar 30, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@deansheather deansheather deansheather approved these changes

Assignees

@kylecarbs kylecarbs

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kylecarbs @deansheather