Skip to content

chore: use defer instead of t.Cleanup for chdir #6887

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 30, 2023
Merged

chore: use defer instead of t.Cleanup for chdir #6887

merged 1 commit into from
Mar 30, 2023
+1 −4

Conversation

kylecarbs
Copy link
Member

This might resolve the races in TestTemplatePush.

@kylecarbs
chore: use defer instead of t.Cleanup for chdir
633176e 
This _might_ resolve the races in `TestTemplatePush`.
@kylecarbs kylecarbs requested a review from deansheather March 30, 2023 14:41
@kylecarbs kylecarbs self-assigned this Mar 30, 2023
@kylecarbs kylecarbs merged commit 1f600fc into main Mar 30, 2023
@kylecarbs kylecarbs deleted the rmrace branch March 30, 2023 14:48
@github-actions github-actions bot locked and limited conversation to collaborators Mar 30, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@deansheather deansheather deansheather approved these changes

Assignees

@kylecarbs kylecarbs

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kylecarbs @deansheather