Skip to content

chore: dial the remote socket continually until connect #6891

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 30, 2023
Merged

chore: dial the remote socket continually until connect #6891

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
chore: dial the remote socket continually until connect 
It's possible that the command starts but the socket isn't ready
even when the file exists.
  • Loading branch information
@kylecarbs
kylecarbs committed Mar 30, 2023
commit b95e8bf489d031371291c7731097b8d8b970feb6
11 changes: 6 additions & 5 deletions agent/agent_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -673,13 +673,14 @@ func TestAgent_UnixRemoteForwarding(t *testing.T) {
err = cmd.Start()
require.NoError(t, err)

// It's possible that the socket is created but the server is not ready to
// accept connections yet. We need to retry until we can connect.
var conn net.Conn
require.Eventually(t, func() bool {
_, err := os.Stat(remoteSocketPath)
var err error
conn, err = net.Dial("unix", remoteSocketPath)
return err == nil
}, testutil.WaitLong, testutil.IntervalFast)

conn, err := net.Dial("unix", remoteSocketPath)
require.NoError(t, err)
}, testutil.WaitShort, testutil.IntervalFast)
defer conn.Close()
_, err = conn.Write([]byte("test"))
require.NoError(t, err)
Expand Down