Skip to content

feat(site): Display workspace build error + option to retry in debug mode #6903

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 10 commits into from
Mar 31, 2023
Merged

feat(site): Display workspace build error + option to retry in debug mode #6903

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
00c6ad6
Clean up workspace machine
BrunoQuaresma Mar 30, 2023
4601bac
Simplify quotas
BrunoQuaresma Mar 30, 2023
bebc6aa
feat(site): Display build error
BrunoQuaresma Mar 30, 2023
0de9205
Merge branch 'main' into bq/display-build-error
BrunoQuaresma Mar 31, 2023
734775c
Pass debug level instead of debug flag
BrunoQuaresma Mar 31, 2023
97fe930
Only show try again if user can update it
BrunoQuaresma Mar 31, 2023
b3e0132
Fixed permissions and storybook
BrunoQuaresma Mar 31, 2023
469cfdb
Merge branch 'main' into bq/display-build-error
BrunoQuaresma Mar 31, 2023
768b4cb
Add translation
BrunoQuaresma Mar 31, 2023
c8e97bf
Merge branch 'main' into bq/display-build-error
BrunoQuaresma Mar 31, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Pass debug level instead of debug flag
  • Loading branch information
@BrunoQuaresma
BrunoQuaresma committed Mar 31, 2023
commit 734775c653b3d88cff4218cd5841e15ff3cc701e
18 changes: 12 additions & 6 deletions site/src/api/api.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -489,22 +489,28 @@ export const postWorkspaceBuild = async (
export const startWorkspace = (
workspaceId: string,
templateVersionID: string,
debug = false,
logLevel?: TypesGen.CreateWorkspaceBuildRequest["log_level"],
) =>
postWorkspaceBuild(workspaceId, {
transition: "start",
template_version_id: templateVersionID,
log_level: debug ? "debug" : undefined,
log_level: logLevel,
})
export const stopWorkspace = (workspaceId: string, debug = false) =>
export const stopWorkspace = (
workspaceId: string,
logLevel?: TypesGen.CreateWorkspaceBuildRequest["log_level"],
) =>
postWorkspaceBuild(workspaceId, {
transition: "stop",
log_level: debug ? "debug" : undefined,
log_level: logLevel,
})
export const deleteWorkspace = (workspaceId: string, debug = false) =>
export const deleteWorkspace = (
workspaceId: string,
logLevel?: TypesGen.CreateWorkspaceBuildRequest["log_level"],
) =>
postWorkspaceBuild(workspaceId, {
transition: "delete",
log_level: debug ? "debug" : undefined,
log_level: logLevel,
})

export const cancelWorkspaceBuild = async (
Expand Down
12 changes: 6 additions & 6 deletions site/src/xServices/workspace/workspaceXService.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -76,7 +76,7 @@ export interface WorkspaceContext {
// applications
applicationsHost?: string
// debug
debugMode?: boolean
createBuildLogLevel?: TypesGen.CreateWorkspaceBuildRequest["log_level"]
}

export type WorkspaceEvent =
Expand Down Expand Up @@ -615,8 +615,8 @@ export const workspaceMachine = createMachine(
},
}),
// Debug mode when build fails
enableDebugMode: assign({ debugMode: (_) => true }),
disableDebugMode: assign({ debugMode: (_) => false }),
enableDebugMode: assign({ createBuildLogLevel: (_) => "debug" as const }),
disableDebugMode: assign({ createBuildLogLevel: (_) => undefined }),
},
guards: {
moreBuildsAvailable,
Expand Down Expand Up @@ -661,7 +661,7 @@ export const workspaceMachine = createMachine(
const startWorkspacePromise = await API.startWorkspace(
context.workspace.id,
context.workspace.latest_build.template_version_id,
context.debugMode,
context.createBuildLogLevel,
)
send({ type: "REFRESH_TIMELINE" })
return startWorkspacePromise
Expand All @@ -673,7 +673,7 @@ export const workspaceMachine = createMachine(
if (context.workspace) {
const stopWorkspacePromise = await API.stopWorkspace(
context.workspace.id,
context.debugMode,
context.createBuildLogLevel,
)
send({ type: "REFRESH_TIMELINE" })
return stopWorkspacePromise
Expand All @@ -685,7 +685,7 @@ export const workspaceMachine = createMachine(
if (context.workspace) {
const deleteWorkspacePromise = await API.deleteWorkspace(
context.workspace.id,
context.debugMode,
context.createBuildLogLevel,
)
send({ type: "REFRESH_TIMELINE" })
return deleteWorkspacePromise
Expand Down