Skip to content

fix: FE show correct config-ssh prefix #6904

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Mar 31, 2023
Merged

fix: FE show correct config-ssh prefix #6904

merged 3 commits into from
Mar 31, 2023

Conversation

Emyrk
Copy link
Member

@Emyrk Emyrk commented Mar 30, 2023

Fixes: #6881

API Response:

{"hostname_prefix":"test.","ssh_config_options":{}}

Screenshot from 2023-03-30 15-34-20

@Emyrk Emyrk requested a review from BrunoQuaresma March 30, 2023 20:35
BrunoQuaresma
BrunoQuaresma approved these changes Mar 31, 2023
View reviewed changes
Copy link
Collaborator

@BrunoQuaresma BrunoQuaresma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like we have one more FE person haha. LGTM

@Emyrk Emyrk merged commit 901045a into main Mar 31, 2023
@Emyrk Emyrk deleted the stevenmasley/ssh_prefix branch March 31, 2023 13:48
@github-actions github-actions bot locked and limited conversation to collaborators Mar 31, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@BrunoQuaresma BrunoQuaresma BrunoQuaresma approved these changes

Assignees

@Emyrk Emyrk

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

front end does not wire in CODER_SSH_HOSTNAME_PREFIX
2 participants
@Emyrk @BrunoQuaresma